Creating miq_request for CustomButton request call with open_url. #17802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works like a charm with |
|
Is this still a WIP? |
pkomanek
changed the title
|
Should be good to merge. I merged the UI part. |
gmcculloug
reviewed
Aug 17, 2018
| @@ -38,7 +38,11 @@ def process_request(state) | |||
| result[:request] = generate_request(state, values) | |||
| else | |||
| ra = load_resource_action(values) | |||
| ra.deliver_to_automate_from_dialog(values, @target, @requester) | |||
| if ra.resource_type == 'CustomButton' && CustomButton.find(ra.resource_id).options[:open_url] | |||
There was a problem hiding this comment.
This object should not have intimate knowledge of the CustomButton model. I would expect that the CustomButton model should be updated to include a open_url? method which would look into the options hash.
Also, I would prefer not using resource_type to identify the object. It would be better to use ra.resource.kind_of?(CustomButton) but in this case I think you just want: if ra.resource.try(:open_url?)
pkomanek
changed the title
|
Checked commit pkomanek@6be7df7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
pkomanek
changed the title
pkomanek
deleted the
creating_miq_task_for_ae_method_from_custom_button_with_open_url
branch
bdunne
added a commit
to bdunne/manageiq
that referenced
this pull request
Aug 28, 2018
ManageIQ#17802 added a line that called [] on options and if nil, it would raise NoMethodError where it should have returned nil
bdunne
added a commit
to bdunne/manageiq
that referenced
this pull request
Aug 28, 2018
ManageIQ#17802 added a line that called [] on options and if nil, it would raise NoMethodError where it should have returned nil
simaishi
pushed a commit
that referenced
this pull request
Sep 11, 2018
…od_from_custom_button_with_open_url Creating miq_request for CustomButton request call with open_url. (cherry picked from commit 5bcea52) https://bugzilla.redhat.com/show_bug.cgi?id=1618800
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new miq_task for CustomButton request call with open_url. This miq_task is used to track ae_method progress, which is used to open specified url when the method is finished. This PR is based on BZ bellow and it is also part of the ManageIQ/manageiq-ui-classic#4334.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1602023