-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L10N - Add the missing pb and eb types for storage_units #17800
Conversation
@miq-bot add_label bug |
@miq-bot add_label gaprindashvili/yes |
I think that we should not be restricting this problem to Japanese locale only, chances are that the problem would show with the other locales too. So I'd say we need to do similar changes to |
44c8187
to
8bcb6dc
Compare
Checked commit lgalis@8bcb6dc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
a single locale for a hotfix sounds good. |
@mzazrivec, @kbrock - added the other locales |
@lgalis the updates to the gem have already been applied 🎉 |
@miq-bot add_label blocker |
L10N - Add the missing pb and eb types for storage_units (cherry picked from commit 2c4361a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1629091
Gaprindashvili backport details:
|
Temporary fix until the rails-i18N gem is updated ( svenfuchs/rails-i18n#790)
L10N - Add the missing pb and eb types for storage_units for JA
@mzazrivec - thanks
Links
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610586
Steps for Testing/QA
Before - 500 errror
After:
Test on a Japanese appliance with a datastore with total_space in the PB range