Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L10N - Add the missing pb and eb types for storage_units #17800

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Aug 3, 2018

Temporary fix until the rails-i18N gem is updated ( svenfuchs/rails-i18n#790)

L10N - Add the missing pb and eb types for storage_units for JA

@mzazrivec - thanks

Links

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610586

Steps for Testing/QA

Before - 500 errror

After:
screenshot from 2018-08-06 10-27-20


Test on a Japanese appliance with a datastore with total_space in the PB range

@lgalis
Copy link
Contributor Author

lgalis commented Aug 3, 2018

@miq-bot add_label bug

@lgalis
Copy link
Contributor Author

lgalis commented Aug 3, 2018

@miq-bot add_label gaprindashvili/yes

@mzazrivec
Copy link
Contributor

I think that we should not be restricting this problem to Japanese locale only, chances are that the problem would show with the other locales too. So I'd say we need to do similar changes to en.yml, es.yml, fr.yml, pt_BR.yml and zh_CN.yml.

@lgalis lgalis changed the title L10N - Add the missing pb and eb types for storage_units for JA L10N - Add the missing pb and eb types for storage_units Aug 6, 2018
@lgalis lgalis force-pushed the add_pb_and_eb_to_storage_units branch from 44c8187 to 8bcb6dc Compare August 6, 2018 14:24
@miq-bot
Copy link
Member

miq-bot commented Aug 6, 2018

Checked commit lgalis@8bcb6dc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@kbrock
Copy link
Member

kbrock commented Aug 6, 2018

a single locale for a hotfix sounds good.
for a full backport, the other locales would be a good choice

@lgalis lgalis closed this Aug 6, 2018
@lgalis lgalis reopened this Aug 6, 2018
@lgalis
Copy link
Contributor Author

lgalis commented Aug 6, 2018

@mzazrivec, @kbrock - added the other locales

@kbrock
Copy link
Member

kbrock commented Aug 8, 2018

@lgalis the updates to the gem have already been applied 🎉

@kbrock kbrock self-assigned this Aug 8, 2018
@kbrock kbrock added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 8, 2018
@kbrock kbrock merged commit 2c4361a into ManageIQ:master Aug 8, 2018
@JPrause
Copy link
Member

JPrause commented Sep 14, 2018

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request Sep 17, 2018
L10N - Add the missing pb and eb types for storage_units
(cherry picked from commit 2c4361a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1629091
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 60dd67670d324e1cea6caadadeef92836b26f3c8
Author: Keenan Brock <[email protected]>
Date:   Wed Aug 8 16:34:06 2018 -0400

    Merge pull request #17800 from lgalis/add_pb_and_eb_to_storage_units
    
    L10N - Add the missing pb and eb types for storage_units
    (cherry picked from commit 2c4361a3db5dfacaacd17276d925f21d28536f2e)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1629091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants