Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Include task_id in result of ResourceActionWorkflow#process_request #17794

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Aug 2, 2018

This was a wrong idea as the method doesn't return the task's id but a MiqQueue records's ID that is useless. So reverting ... sorry.

@miq-bot assign @gmcculloug

This reverts commit 25be312.

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2018

Some comments on commit skateman@c211bf0

spec/models/resource_action_workflow_spec.rb

  • ⚠️ - 104 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2018

Checked commit skateman@c211bf0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@gmcculloug gmcculloug merged commit 2cf9e75 into ManageIQ:master Aug 2, 2018
@gmcculloug gmcculloug added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 2, 2018
@skateman skateman deleted the revert-taskid branch August 2, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants