Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply gettext to initial & error service dialog values #17789

Conversation

mzazrivec
Copy link
Contributor

We apply N_() on the backend part and will apply _() in UI.

https://bugzilla.redhat.com/show_bug.cgi?id=1592573

@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2018

Checked commit mzazrivec@f429ed3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 🍰

@bdunne bdunne merged commit ca3c870 into ManageIQ:master Aug 1, 2018
@bdunne bdunne self-assigned this Aug 1, 2018
@bdunne bdunne added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 1, 2018
@mzazrivec mzazrivec deleted the apply_gettext_to_initial_and_error_dialog_values branch August 2, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants