Add internal attribute to service template

[hsong-rh]

Add internal attribute to service template table.

Depend on PR: ManageIQ/manageiq-schema#238

https://bugzilla.redhat.com/show_bug.cgi?id=1594408

[hsong-rh]

@bzwei @gmcculloug Please review.

[Fryguy]

@hsong-rh Since this is upstream, can you remove the upstream wording from your commit and PR title as they make no sense.

[hsong-rh]

@Fryguy Words removed.

[miq-bot]

Checked commit hsong-rh@28ee034 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[hsong-rh]

@gmcculloug Schema PR was merged, build passed. Please merge. Thanks.

[lpichler]

@hsong-rh @gmcculloug @bzwei I think I found a bug.

which boolean value means ServiceTemplate#internal = nil ?

objects.second.class =>
ServiceTemplateCatalog

(byebug) objects.second.service_templates.map {|x| [x.service_template_catalog_id, x.internal] } =>
[[75000000000001, nil], [75000000000001, nil], [75000000000001, nil], [75000000000001, nil]]

objects.second.service_templates.public_service_templates =>
[]

objects.second.service_templates.where.not(:internal => true) =>
[]

it is not considering NULL values because of so-called three value logic.

https://stackoverflow.com/questions/17679721/why-does-postgresql-not-return-null-values-when-the-condition-is-true

or NULL values should be covered by sql migration ?

thanks!

[hsong-rh]

@lpichler We shouldn't have the case of internal = nil. In the base class, its default value is set to false, and only be true if the type is ServiceTemplateTransformationPlan. Are objects.second.service_templates the type of ServiceTemplateTransformationPlan?

[lpichler]

@hsong-rh No, type is nil. And it is possible because of internal column has been added
https://github.com/ManageIQ/manageiq-schema/pull/238/files#diff-1d061c844b9d792d54472130a429e360R10 without default value false - which is ok according to our recommendations.

but in this case you have to set false value in migration to cover also other ServiceTemplate or change the query.

[bzwei]

@lpichler I were aware of this three value logic issue when I was testing this PR. I could not remember what was the code that passed all manual tests nor can I understand how the PR finally ended up at this state. Nevertheless the following fix seems working:

scope :public_service_templates,                  ->         { where(:internal => [false, nil]) }

[gmcculloug]

@lpichler the default value is set using default_value_for on the model instead of at the db level.

https://github.com/ManageIQ/manageiq/blob/master/app/models/service_template.rb#L73
https://github.com/ManageIQ/manageiq/blob/master/app/models/service_template_transformation_plan.rb#L10