Include the request_type when creating a retirement request

[bdunne]

Depends on ManageIQ/manageiq-api#439

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1604016

[miq-bot]

Checked commit bdunne@46dc853 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

[carbonin]

@d-m-u @tinaafitz If retirement is being done as a request, does Vm even respond to #retire anymore?

I'm asking because I'm wondering if we should remove https://github.com/ManageIQ/manageiq/blob/master/app/models/vm/operations/lifecycle.rb#L21-L25 or is it still valid to call retire directly on a Vm or Service object?

[carbonin]

Oh I see, we added a method to the mixin rather than replacing the existing retire method.

So it sounds like this broke when retirement went from a direct method on the Vm object to a request.

Now instead of pushing the retire action over the API for central admin on the resource this PR is giving us the information we need for when we relay the create_request method.

[bdunne]

Correct, now that it's hitting create_request which will be relayed to the remote region, we need to include the type of request for the remote region to parse.

[carbonin]

Makes sense to me. 👍

[carbonin]

When was the retirement-as-a-request added? Does this need to be backported?

[bdunne]

I don't think it made it back to g-branch. @tinaafitz @d-m-u Can you confirm?

[tinaafitz]

@bdunne That is correct. The new retirement as a request changes were not back ported to the g-branch.