Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to create default dashboard for group #17778

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Jul 30, 2018

BEFORE: We have one default dashboards (supplied with installation).
This dashboard defined in product/dashboard/dashboards/default.yaml

AFTER: ability to supply group specific default dashboard.

TESTING creating dashboard for group EvmGroup-support with the same set of widgets as existing default dashboard:

  • copy product/dashboard/dashboards/default.yaml to product/dashboard/dashboards/some_file.yaml
  • edit some_file.yaml by changing name: and description: and adding owner_type: MiqGroup and owner_description: EvmGroup-support. It will look like:
name: Default for Support
read_only: t
set_type: MiqWidgetSet
description: Default Dashboard for Support group
owner_type: MiqGroup
owner_description: EvmGroup-support
set_data_by_description:
  :col1:
  - chart_vendor_and_guest_os
  - rss_newest_hosts
  - report_top_memory_consumers_weekly
  :col2:
  - report_top_cpu_consumers_weekly
  - chart_virtual_infrastructure_platforms
  :col3:
  - chart_guest_os_information_any_os
  - rss_newest_vms
  - report_top_storage_consumers

Executing MiqWidgetSet.seed from Rails console will add new dashboard for EvmGroup-support

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610299

@miq-bot add-label enhancement, reporting

\cc @gtanzillo

@yrudman yrudman changed the title Allow creation of default dashboard per group [WIP] Allow creation of default dashboard per group Jul 30, 2018
@miq-bot miq-bot added the wip label Jul 30, 2018
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yrudman yrudman changed the title [WIP] Allow creation of default dashboard per group Added ability to create default dashboard for group Jul 31, 2018
@miq-bot miq-bot removed the wip label Jul 31, 2018
@yrudman yrudman force-pushed the default-dashboard-by-group branch from 965c393 to 4c56fb1 Compare July 31, 2018 14:15
@yrudman yrudman force-pushed the default-dashboard-by-group branch from 4c56fb1 to a82d6a1 Compare July 31, 2018 14:39
@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2018

Checked commits yrudman/manageiq@c8c8277~...a82d6a1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@yrudman
Copy link
Contributor Author

yrudman commented Aug 2, 2018

@jrafanie could you review

@gtanzillo gtanzillo self-assigned this Aug 2, 2018
@gtanzillo gtanzillo added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 2, 2018
@gtanzillo gtanzillo merged commit 12bfb59 into ManageIQ:master Aug 2, 2018
@yrudman yrudman deleted the default-dashboard-by-group branch August 2, 2018 15:56
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants