Ansible runner allow to run roles without playbook #17757

Ladas · 2018-07-25T13:28:18Z

Ansible runner allow to run roles without playbook

The example usage is:

Ansible::Runner.run_role(ext_management_system.parent_manager.ansible_env_vars,
                             {
                               :vpc_id                      => options["vpc_id"],
                               :security_group_name         => options["security_group_name"],
                               :security_group_description  => options["security_group_description"],
                               :security_group_rules        => options["security_group_rules"],
                               :security_group_rules_egress => options["security_group_rules_egress"],
                             },
                             "create_security_group",
                             :roles_path => File.join(ext_management_system.parent_manager.ansible_root, "roles")

    )

So we run a role directly and we do not need to write a playbook like https://github.com/ManageIQ/manageiq-providers-amazon/pull/453/files#diff-043bd0af7eaf90b61c703f5629a40845 , since that will be generated for us

Allow to run role without playbook

Allow to run run_role via queue

Fix the queue methods args

Ladas · 2018-07-25T13:30:11Z

@miq-bot assign @agrare
@miq-bot add_label enhancement

Ladas · 2018-07-25T13:31:13Z

@miha-plesko @borod108 this way, we can call the roles directly and we can delete the simple playbooks

miha-plesko · 2018-07-25T13:48:18Z

lib/ansible/runner.rb

+        run_via_cli(env_vars, extra_vars, :playbook_path => playbook_path)
+      end
+
+      def run_role(env_vars, extra_vars, role_name, roles_path:, role_skip_facts: true)


For Galaxy roles, roles_path argument won't mean anything because they are installed globally AFAIK. We would probably want to make it optional.

right, but right now ansible-runner looks only in the working dir, I need to create an Issue so it also checks the system roles/galaxy roles. So right now, we need to provide the right path ourselves (or I could put there a default value ?)

@agrare although we probably didn't want to install the roles in a global dir, because of the possible conflicts with other providers?

Right we'll need to look into if we can install galaxy roles to directories other than a global location. Ideally we would scope this to per-provider repos so nothing conflicts.

miha-plesko · 2018-07-25T13:55:37Z

lib/ansible/runner.rb

+
+        if roles_path
+          role_params[:"roles-path"] = roles_path
+        end


Suggest we inline it with

role_params[:"roles-path"] = roles_path if roles_path

miha-plesko · 2018-07-25T13:56:18Z

lib/ansible/runner.rb

+        end
+
+        if role_skip_facts
+          role_params[:"role-skip-facts"] = nil


I think we should set to true here instead nil

right, this argument is without value

so it's like ansible-runner XY vs. ansible-runner XY --role-skip-facts

Simplify the role param condition

Fix circular argument reference

miq-bot · 2018-07-25T15:35:23Z

Checked commits Ladas/manageiq@93bdb15~...00bd9be with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

…s_without_playbook Ansible runner allow to run roles without playbook

agrare · 2018-07-26T18:30:02Z

lib/ansible/runner.rb

        unless File.exist?(path)
          raise "File doesn't exist: #{path}"
        end
      end

      def ansible_command(base_dir)
-        # TODO add possibility to use custom path, e.g. from virtualenv
-        "ansible-runner run #{base_dir} --json -i result"
+        "ansible-runner run #{base_dir} --json -i result --hosts localhost"


Future stuff but we might want to make the --hosts configurable if people want to run playbooks on other systems i.e. post-provisioning

Ladas added 3 commits July 25, 2018 15:29

Allow to run role without playbook

93bdb15

Allow to run role without playbook

Allow to run run_role via queue

44b6e6b

Allow to run run_role via queue

Fix the queue methods args

18f9abb

Fix the queue methods args

Ladas force-pushed the ansible_runner_allow_to_run_roles_without_playbook branch from 300612c to 18f9abb Compare July 25, 2018 13:29

miq-bot assigned agrare Jul 25, 2018

miq-bot added the enhancement label Jul 25, 2018

miha-plesko reviewed Jul 25, 2018

View reviewed changes

Ladas added 2 commits July 25, 2018 17:29

Simplify the role param condition

116946d

Simplify the role param condition

Fix circular argument reference

00bd9be

Fix circular argument reference

Ladas mentioned this pull request Jul 26, 2018

Ansible runner add missing yard docs #17761

Merged

1 task

agrare approved these changes Jul 26, 2018

View reviewed changes

agrare merged commit 00bd9be into ManageIQ:master Jul 26, 2018

agrare added a commit that referenced this pull request Jul 26, 2018

Merge pull request #17757 from Ladas/ansible_runner_allow_to_run_role…

f95da7f

…s_without_playbook Ansible runner allow to run roles without playbook

agrare added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 26, 2018

agrare reviewed Jul 26, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ansible runner allow to run roles without playbook #17757

Ansible runner allow to run roles without playbook #17757

Ladas commented Jul 25, 2018 •

edited

Loading

Ladas commented Jul 25, 2018

Ladas commented Jul 25, 2018 •

edited

Loading

miha-plesko Jul 25, 2018

Ladas Jul 25, 2018

Ladas Jul 25, 2018

agrare Jul 25, 2018

miha-plesko Jul 25, 2018

miha-plesko Jul 25, 2018

Ladas Jul 25, 2018

miq-bot commented Jul 25, 2018

agrare Jul 26, 2018

Ansible runner allow to run roles without playbook #17757

Ansible runner allow to run roles without playbook #17757

Conversation

Ladas commented Jul 25, 2018 • edited Loading

Ladas commented Jul 25, 2018

Ladas commented Jul 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miq-bot commented Jul 25, 2018

Choose a reason for hiding this comment

Ladas commented Jul 25, 2018 •

edited

Loading

Ladas commented Jul 25, 2018 •

edited

Loading