Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] locale:po_to_json: add support for including catalogs from js plugins #17740

Conversation

mzazrivec
Copy link
Contributor

This is gaprindashvili version of #17725

When creating gettext catalogs for javascript consumption, we need to merge catalogs from all ManageIQ plugins and convert the result into a json file. So far, we were only able to do that for regular rails engines (i.e. ManageIQ ruby plugins). As things are, we need to include javascript plugins (such as ui-compoments) into the equation as well.

This change makes it possible to download the gettext catalogs from plugins and include them into the merge & conversion process.

(cherry picked from commit 60bac82)

https://bugzilla.redhat.com/show_bug.cgi?id=1592571

@mzazrivec mzazrivec force-pushed the locale_po_to_json_add_support_for_javascript_plugins_gaprindashvili branch from 70d3265 to 23aed0a Compare July 24, 2018 08:33
@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commit mzazrivec@23aed0a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 7 offenses detected

lib/tasks/locale.rake

@JPrause
Copy link
Member

JPrause commented Jul 24, 2018

@miq-bot add_label blocker

@JPrause
Copy link
Member

JPrause commented Aug 1, 2018

@martinpovolny did you need to review further before this is merged.

Copy link
Member

@martinpovolny martinpovolny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JPrause
Copy link
Member

JPrause commented Aug 3, 2018

@simaishi with Martin's approval, will you be doing the merge.

@simaishi simaishi merged commit 8ed7a4d into ManageIQ:gaprindashvili Aug 5, 2018
@simaishi simaishi added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants