Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting physical switch to computer systems #17735

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

douglasgabriel
Copy link
Member

@douglasgabriel douglasgabriel commented Jul 20, 2018

This PR is able to

  • Add a route to get the connected component from physical_switch.

More details
The connected component could be any managed_entity of ComputerSystem entity that has PhysicalNetworkPort parsed

@douglasgabriel
Copy link
Member Author

@miq-bot assign @agrare

@douglasgabriel douglasgabriel changed the title Connecting physical switch to computer systems [WIP] Connecting physical switch to computer systems Jul 25, 2018
@miq-bot miq-bot added the wip label Jul 25, 2018
@douglasgabriel douglasgabriel force-pushed the cnt_comp_sys branch 3 times, most recently from 069b38b to c4c9d20 Compare July 25, 2018 17:51
@douglasgabriel douglasgabriel changed the title [WIP] Connecting physical switch to computer systems Connecting physical switch to computer systems Jul 25, 2018
@miq-bot miq-bot removed the wip label Jul 25, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2018

Checked commit douglasgabriel@4a7a121 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM

agrare added a commit to agrare/manageiq that referenced this pull request Jul 26, 2018
Connecting physical switch to computer systems
@agrare agrare merged commit 4a7a121 into ManageIQ:master Jul 26, 2018
@agrare agrare added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants