Add rake task to import custom buttons

[d-m-u]

We need to be able to import custom buttons via a rake task.

Related export PR: #17699

Importing

Import cbs:
rake evm:import:custom_buttons -- --source /Users/duhlmann/manageiq/custom_buttons

Note: this works either for a single file or for a directory.

The command for a single file looks like this:
rake evm:import:custom_buttons -- --source /Users/duhlmann/manageiq/custom_buttons.yaml

[d-m-u]

@miq-bot add_label enhancement, wip

[d-m-u]

@tinaafitz @syncrou @eclarizio
@whoever_wants_to_review_me

[d-m-u]

Okay, fine. WIP cause 1) tests failing 2) yaml linting 3) need flag to overwrite existing thingies being imported. May handle 3 in subsequent PR.

[syncrou]

@d-m-u - I found I needed the file extension e.g. rake evm:import:custom_buttons -- --source /Users/duhlmann/manageiq/custom_buttons.yaml to get the task to load the file.

[gmcculloug]

Suggest: rescue StandardError

[gmcculloug]

Should check_user be passed new_obj?

Since code complexity is high on this method maybe we should break the if-blocks out into separate methods.

klass.create!(obj['attributes'].except('guid')).tap do |new_obj|
  add_children(obj, new_obj)
  add_associations(obj, new_obj)
  check_user(new_obj)
end

[gmcculloug]

This logic should be called from custom_button_post. Then you do not need this check for the class type.

[gmcculloug]

@eclarizio PTAL

[eclarizio]

Looks good aside from a question I have with the error handling. 👍

[eclarizio]

Two things here (I think?), first is that, if we get here, aren't we getting here because of the raise from here: https://github.com/ManageIQ/manageiq/pull/17726/files#diff-a0ce4acbb7481b72b585132391c2dd4cR28, which means that this will just say something like "error because of raise at line 28?" and not give us actual good info?

Second is that I think there is the potential for YAML.load_file to fail if the YAML is messed up, in which case I don't remember if StandardError will catch it, cause it's a Psych error or something I think. Maybe?

In either case, maybe some specs ensuring the errors are doing what you want them to do are a good solution to my worries 😄

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[d-m-u]

I think these failures are unrelated.

[miq-bot]

Checked commits d-m-u/manageiq@f8ca9bf~...e2d1697 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

lib/task_helpers/imports/custom_buttons.rb

• ❗ - Line 11, Col 68 - Style/SpecialGlobalVars - Prefer $ERROR_POSITION from the stdlib 'English' module (don't forget to require it) over $@.

[eclarizio]

👍