Fix refresh time and memory issues #17724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the key method on InventoryObject to avoid the .try()
Remove the dynaminc readers and writers since they can cause massive spikes in memory and processing time. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1600253
|
Checked commits Ladas/manageiq@f570ecc~...b893632 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
👍 confirmed this fixes the memory+time spike, will merge after provider plugin spec tests passing. |
agrare
approved these changes
Jul 18, 2018
agrare
added a commit
that referenced
this pull request
Jul 18, 2018
Fix refresh time and memory issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing spikes in memory and time
https://bugzilla.redhat.com/show_bug.cgi?id=1600253