-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service AnsibleTower and EmbeddedAnsible UI parity #17712
Conversation
@miq-bot add_label enhancement, automate, providers/ansible_tower |
49118f8
to
0385c05
Compare
Checked commits tumido/manageiq@71ef10a~...0385c05 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@gmcculloug the dependent ManageIQ/manageiq-providers-ansible_tower#108 is merged. |
Make the service layout same for AnsibleTower as it is for EmbeddedAnsible - Core part
:raw_stdout_via_worker
to shared Ansible codebase:job
signature the same in service_ansible_tower.rb and service_ansible_playbook.rbDepends on: ManageIQ/manageiq-providers-ansible_tower#108
Other related PR: ManageIQ/manageiq-ui-classic#4299
Fixes: BUG 1590840 BUG 1590844