put S3 refresh in a separate worker #17704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
approved these changes
Jul 16, 2018
|
@Ladas we moved the child managers into a single worker because of races with targeted refresh right? Is that not a concern with the S3 manager? |
|
@agrare should not be, S3 entities are not connected to anything from the other managers, nor there is a targeted refresh for it. (I believe it was the targeted refresh doing the race, since it would be 2 workers saving the same records) |
|
@agrare Yeah should be ok :) |
|
Okay thanks guys, I'm good with this then. I assume this has to be merged right before the amazon PR. When you two approve it I'll merge both together. |
AlexanderZagaynov
force-pushed
the
BZ-1541435
branch
from
f7f09a8 to
0c82f49
Compare
|
Checked commit AlexanderZagaynov@0c82f49 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Aug 1, 2018
agrare
added a commit
that referenced
this pull request
Aug 1, 2018
put S3 refresh in a separate worker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1541435
Put S3 refresh in a separate worker, as it can contain too many objects, which blocks other data refresh.
Coupled PR: ManageIQ/manageiq-providers-amazon#461