Stop falling back to old_ems_id, drop OldEmsMixin #17695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ems_id always set since we switched to soft delete. Backfilled for old records too by ManageIQ/manageiq-schema#18.
ems_id always set since we switched to soft delete. Backfilled for old records too by ManageIQ/manageiq-schema#18.
|
Checked commits cben/manageiq@299e50c~...fdbf283 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
approved these changes
Jul 11, 2018
zeari
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step for ManageIQ/manageiq-providers-kubernetes#196. ✂️ 🔥 ✂️
ems_idis always set now (and was backfilled for old disconnected objects too).@yaacov @zeari Please review.
Do I need(UPDATE: not enough, fails test) or all 5 models that included OldEmsMixin?my_zoneonly on the 3 models that have metrics@miq-bot add-label technical debt, gaprindashvili/no