Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automation_manager should use :manager(_id) instead of :ems_id #17694

Merged
merged 1 commit into from
Jul 11, 2018
Merged

automation_manager should use :manager(_id) instead of :ems_id #17694

merged 1 commit into from
Jul 11, 2018

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Jul 11, 2018 •
edited
Loading

#17621 is breaking https://travis-ci.org/ManageIQ/manageiq-providers-ansible_tower/jobs/402774240

 1) ManageIQ::Providers::AnsibleTower::AutomationManager::Refresher behaves like ansible refresher will perform a full refresh
     Failure/Error: record = inventory_collection.model_class.create!(hash.except(:id))
     ActiveModel::UnknownAttributeError:
       unknown attribute 'ems_id' for ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationWorkflow.
     Shared Example Group: "ansible refresher" called from ./spec/models/manageiq/providers/ansible_tower/automation_manager/refresher_spec.rb:8

@miq-bot miq-bot added the wip label Jul 11, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 11, 2018

Checked commit jameswnl@ff53452 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@jameswnl jameswnl changed the title [WIP] automation_manager should use :manager(_id) instead of :ems_id automation_manager should use :manager(_id) instead of :ems_id Jul 11, 2018
@miq-bot miq-bot removed the wip label Jul 11, 2018
@jameswnl
Copy link
Contributor Author

@miq-bot assign @agrare

@jameswnl
Copy link
Contributor Author

@miq-bot add_labels bug

@miq-bot miq-bot added the bug label Jul 11, 2018
agrare
agrare approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @jameswnl !

@agrare agrare merged commit ff53452 into ManageIQ:master Jul 11, 2018
agrare added a commit that referenced this pull request Jul 11, 2018
@agrare
Merge pull request #17694 from jameswnl/fix-ic
a72b40d 
automation_manager should use :manager(_id) instead of :ems_id
@agrare agrare added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug providers/automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameswnl @miq-bot @agrare @Fryguy