Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope ui and api server searches to recently active servers #17670

Merged
merged 2 commits into from
Jul 10, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 5, 2018

Prevents attempts to contact UI / API workers on servers that may be inaccessible

https://bugzilla.redhat.com/show_bug.cgi?id=1594704

@miq-bot
Copy link
Member

miq-bot commented Jul 5, 2018

Checked commits bdunne/manageiq@4988e72~...b0ab37b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@bdunne bdunne requested review from Fryguy and gtanzillo July 5, 2018 17:13
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 10, 2018
@gtanzillo gtanzillo self-assigned this Jul 10, 2018
@gtanzillo gtanzillo merged commit ebfcf7c into ManageIQ:master Jul 10, 2018
@bdunne bdunne deleted the only_contact_active_ws_servers branch July 10, 2018 13:27
@simaishi
Copy link
Contributor

@bdunne Backport to Gaprindashvili is conflicting on the spec file. If I can take everything from #remote_ui_url to the end of the file (that is, #remote_ui_url, #remote_ui_miq_server and #remote_ws_miq_server), I'll backport. Otherwise please create a separate PR for G-branch.

bdunne pushed a commit to bdunne/manageiq that referenced this pull request Sep 12, 2018
…servers

Scope ui and api server searches to recently active servers

(cherry picked from commit ebfcf7c)
https://bugzilla.redhat.com/show_bug.cgi?id=1607409
@bdunne
Copy link
Member Author

bdunne commented Sep 18, 2018

Backport PR #17978

bdunne pushed a commit to bdunne/manageiq that referenced this pull request Sep 26, 2018
…servers

Scope ui and api server searches to recently active servers

(cherry picked from commit ebfcf7c)
https://bugzilla.redhat.com/show_bug.cgi?id=1607409
@simaishi
Copy link
Contributor

simaishi commented Oct 3, 2018

Backported to Gaprindashvili via #17978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants