Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding miq_feature to chassis LED operation #17668

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Adding miq_feature to chassis LED operation #17668

merged 1 commit into from
Jul 6, 2018

Conversation

douglasgabriel
Copy link
Member

@douglasgabriel douglasgabriel commented Jul 4, 2018 •
edited
Loading

@miq-bot miq-bot added the wip label Jul 4, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 4, 2018

Checked commit douglasgabriel@3a820b7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@douglasgabriel douglasgabriel changed the title [WIP] Adding miq_feature to chassis LED operation Adding miq_feature to chassis LED operation Jul 4, 2018
@douglasgabriel
Copy link
Member Author

@miq-bot assign @dclarizio

@miq-bot miq-bot removed the wip label Jul 4, 2018
@dclarizio dclarizio requested a review from h-kataria July 5, 2018 15:05
@h-kataria
Copy link
Contributor

h-kataria commented Jul 5, 2018 •
edited
Loading

@douglasgabriel will these be added as toolbar button in UI at some point or are these API only actions, if these are only API actions they should be moved to API section under https://github.com/douglasgabriel/manageiq/blob/3a820b72049e1cb0ebd720fe41aaa93bca43bd24/db/fixtures/miq_product_features.yml#L6334.

@douglasgabriel douglasgabriel mentioned this pull request Jul 6, 2018
Merged
@douglasgabriel
Copy link
Member Author

Yes, a button will be added in UI, as well. By the way, I patched the description with the link for the UI work

@h-kataria h-kataria added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 6, 2018
@h-kataria h-kataria merged commit a572b1a into ManageIQ:master Jul 6, 2018
@dclarizio dclarizio assigned h-kataria and unassigned dclarizio Jul 6, 2018
agrare pushed a commit to agrare/manageiq that referenced this pull request Jul 9, 2018
@h-kataria @agrare
Merge pull request ManageIQ#17668 from douglasgabriel/ph_chassis_actions
a36b013 
Adding miq_feature to chassis LED operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

Assignees

@h-kataria h-kataria

Labels
enhancement providers/physical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@douglasgabriel @miq-bot @h-kataria @Fryguy @dclarizio