Remove Request taggable and prevent tag filtering #17656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @LorkScorguar for reporting this issue and providing the detailed information needed to fix it. |
|
Added fine/yes and gap/yes since #17466 was backported to both. |
MiqRequest was changed to allow ownership for self service and limited self-service users in ManageIQ ManageIQ#17208, BZ #1545395 This caused a problem if you had tag filters assign to a user's group undefined method `find_tags_by_grouping'. This was fixed in ManageIQ ManageIQ#17466, BZ #1576129, and shipped with: Fine: BZ #1583711 Gaprindindashvili: BZ #1583710 Unfortunately, this second fix to add taggable caused a new bug: users in groups having tag filters could not see their own requests. This commit changes MiqRequest to no longer be taggable, since it's not even taggable in the UI and instead, we add MiqRequest to a list of models that are RBAC'able but not taggable so we don't try to filter MiqRequest based on a user's group tag filters. Credit goes to github user LorkScorguar who reported this issue and provided lots of diagnostics to help us fix this properly. To test this, simply assign managed filters to a user's group, such as /managed/environments/production, create a request for that user and try to see that user's request. They couldn't see it if they received the intermediate fix, ManageIQ#17466, or if they didn't receive that fix, they'd receive the `find_tags_by_grouping` error shown above. For gaprindashvili and fine: Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1596738 For hammer: Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1576129
jrafanie
force-pushed
the
remove_miq_request_taggable_and_prevent_tag_filtering_on_it
branch
from
36a25f2 to
f8c0553
Compare
|
Checked commit jrafanie@f8c0553 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
deleted the
remove_miq_request_taggable_and_prevent_tag_filtering_on_it
branch
simaishi
pushed a commit
that referenced
this pull request
Jul 2, 2018
…nd_prevent_tag_filtering_on_it Remove Request taggable and prevent tag filtering (cherry picked from commit b856925) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1597321
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiqRequest was changed to allow ownership for self service and limited
self-service users in ManageIQ #17208, BZ #1545395
This caused a problem if you had tag filters assign to a user's group:
undefined methodfind_tags_by_grouping'`This was fixed in ManageIQ #17466, BZ #1576129, and shipped with:
Fine: BZ #1583711
Gaprindindashvili: BZ #1583710
Unfortunately, this second fix to add taggable caused a new bug: users in
groups having tag filters could not see their own requests.
This commit changes MiqRequest to no longer be taggable, since it's not
even taggable in the UI and instead, we add MiqRequest to a list of
models that are RBAC'able but not taggable so we don't try to filter
MiqRequest based on a user's group tag filters.
Credit goes to github user LorkScorguar who reported this issue and
provided lots of diagnostics to help us fix this properly.
To test this, simply assign managed filters to a user's group, such as
/managed/environments/production, create a request for that user and
try to see that user's request. They couldn't see it if they received
the intermediate fix, #17466, or if they didn't receive that fix, they'd
receive the
find_tags_by_groupingerror shown above.For gaprindashvili and fine:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1596738
For hammer:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1576129