Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display name for PhysicalSwitch model #17655

Merged

Conversation

mzazrivec
Copy link
Contributor

Added both into locale/en.yml and the model itself.

@miq-bot
Copy link
Member

miq-bot commented Jun 29, 2018

Checked commit mzazrivec@150c367 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy Fryguy merged commit 2da30d8 into ManageIQ:master Jul 2, 2018
@Fryguy
Copy link
Member

Fryguy commented Jul 2, 2018

@mzazrivec Is there any way we could write a spec to detect this for future models, or does that not make sense.

@agrare agrare added this to the Sprint 89 Ending Jul 2, 2018 milestone Jul 3, 2018
@mzazrivec
Copy link
Contributor Author

@Fryguy Only certain models require to have display_name() defined: usually those that appear in reports and those which appear in UI in some shape or form (have their own controller, right cell text, are rendered in flash messages, etc.)

Automatic detection here would be quite difficult (and probably not 100% reliable).

@mzazrivec mzazrivec deleted the add_display_name_for_physical_switch branch July 9, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants