Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAPRINDASHVILI] Add option to prov workflow to not rerun methods #17641

Merged
merged 1 commit into from
Jul 11, 2018
Merged

[GAPRINDASHVILI] Add option to prov workflow to not rerun methods #17641

merged 1 commit into from
Jul 11, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Jun 26, 2018 •
edited by simaishi
Loading

Dialogs are being run twice, once on load, once on submit, this lets us reuse the values we picked so they don't rerun on submit.

Master PR: #17642
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1591427
https://bugzilla.redhat.com/show_bug.cgi?id=1595776

There's a related API PR.

It's eclarizio's code.

Also it's WIP cause it needs tests.

Depends on

ManageIQ/manageiq-api#406

c'est the g release version of this fun: #17642 and ManageIQ/manageiq-api#407

@d-m-u d-m-u mentioned this pull request Jun 26, 2018
Merged
@d-m-u
Copy link
Contributor Author

d-m-u commented Jun 26, 2018

@miq-bot add_label g/only
is there even such a label?
My guess is we should front-port in the near-future
@eclarizio thanks and can you 👀 please, am testing now

@miq-bot miq-bot changed the title [WIP] Make prov workflow use the right values, add option to not rerun methods [GAPRINDASHVILI] [WIP] Make prov workflow use the right values, add option to not rerun methods Jun 26, 2018
@miq-bot miq-bot added the wip label Jun 26, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2018

@d-m-u Cannot apply the following label because they are not recognized: g/only

@simaishi
Copy link
Contributor

@d-m-u We need 'master' PR first!

@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2018

Checked commit d-m-u@86e5305 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

@d-m-u
Copy link
Contributor Author

d-m-u commented Jun 26, 2018

@miq-bot add_label performance
@miq-bot add_label bug

@d-m-u d-m-u changed the title [GAPRINDASHVILI] [WIP] Make prov workflow use the right values, add option to not rerun methods [GAPRINDASHVILI] Make prov workflow use the right values, add option to not rerun methods Jun 27, 2018
@miq-bot miq-bot removed the wip label Jun 27, 2018
@d-m-u d-m-u changed the title [GAPRINDASHVILI] Make prov workflow use the right values, add option to not rerun methods [GAPRINDASHVILI] Add option to prov workflow to not rerun methods Jun 28, 2018
@gmcculloug gmcculloug requested a review from eclarizio July 3, 2018 14:37
@JPrause
Copy link
Member

JPrause commented Jul 3, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Jul 3, 2018
@simaishi
Copy link
Contributor

simaishi commented Jul 3, 2018 •
edited
Loading

My guess is we should front-port in the near-future

@d-m-u Not sure if this means there is no PR for 'master' branch? Based on that comment, I'd think this is an issue in 'master' as well? If so, we need PR for master first (and backport that PR, or create G-specific PR if change is different). I can't tell what's happening with master branch...

Never mind... found the master PR. Please link them in the future, thanks!

@JPrause
Copy link
Member

JPrause commented Jul 9, 2018

@eclarizio were you able to review this PR.

eclarizio
eclarizio approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it looks very similar on first glance to #17642, do we need this specific PR or can @simaishi just cherry-pick?

@d-m-u
Copy link
Contributor Author

d-m-u commented Jul 9, 2018

The service template model changed enough that I'd prefer to use this specific one?

@eclarizio
Copy link
Member

That's fine 👍

@simaishi simaishi merged commit 53ad123 into ManageIQ:gaprindashvili Jul 11, 2018
@simaishi simaishi added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 11, 2018
@simaishi simaishi mentioned this pull request Jul 25, 2018
Merged
@d-m-u d-m-u deleted the bz1584355 branch October 25, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclarizio eclarizio eclarizio approved these changes

Assignees

@simaishi simaishi

Labels
blocker bug performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @simaishi @JPrause @eclarizio