Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] Filter relevant fields also according to chargeback class in Chargeback #17639

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jun 26, 2018

@lpichler
Copy link
Contributor Author

@miq-bot assign @simaishi
cc @gtanzillo

@lpichler lpichler force-pushed the remove_column_guard_conditions_in_chargeback_g branch from 0c6d04b to c4fb5ea Compare June 26, 2018 15:54
@simaishi simaishi requested review from jrafanie and removed request for jrafanie June 26, 2018 15:57
@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2018

Checked commit lpichler@c4fb5ea with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green

@simaishi simaishi merged commit 682cecf into ManageIQ:gaprindashvili Jun 26, 2018
@simaishi simaishi added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 26, 2018
@lpichler lpichler deleted the remove_column_guard_conditions_in_chargeback_g branch June 27, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants