Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sorting does not happen when sort_by is set to "none" #17625

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

eclarizio
Copy link
Member

I didn't dig in too deep to track down how the code is getting through this point where the sort_by isn't a symbol, but basically we were ignoring the fact that sort_by in the options was a string instead of a symbol (when creating/updating/editing an existing dialog, the sort_by= code automatically forces it into a symbol so this was getting bypassed).

So, this was causing us to attempt to sort the items in the values list even if the none sort_by value was selected. This will need to be combined with the fix from the ui-components repo here since the javascript code was also attempting to sort even when the sort_by value was none.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1593874

@miq-bot add_label gaprindashvili/yes, bug, blocker
@d-m-u Please review
@miq-bot assign @gmcculloug

/cc @tinaafitz

@miq-bot
Copy link
Member

miq-bot commented Jun 21, 2018

Checked commit eclarizio@145052a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@gmcculloug gmcculloug merged commit 8e109d6 into ManageIQ:master Jun 21, 2018
@gmcculloug gmcculloug added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 21, 2018
simaishi pushed a commit that referenced this pull request Jun 22, 2018
Ensure sorting does not happen when sort_by is set to "none"
(cherry picked from commit 8e109d6)

https://bugzilla.redhat.com/show_bug.cgi?id=1594268
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 9048714a52b4611dadaf1484b3f4fd9b2aa9fa7b
Author: Greg McCullough <[email protected]>
Date:   Thu Jun 21 19:01:27 2018 -0400

    Merge pull request #17625 from eclarizio/BZ1593874
    
    Ensure sorting does not happen when sort_by is set to "none"
    (cherry picked from commit 8e109d6530e8535a5524dbe4050598c210fe72ee)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1594268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants