Ensure sorting does not happen when sort_by is set to "none" #17625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't dig in too deep to track down how the code is getting through this point where the
sort_by
isn't a symbol, but basically we were ignoring the fact thatsort_by
in the options was a string instead of a symbol (when creating/updating/editing an existing dialog, thesort_by=
code automatically forces it into a symbol so this was getting bypassed).So, this was causing us to attempt to sort the items in the values list even if the
none
sort_by value was selected. This will need to be combined with the fix from the ui-components repo here since the javascript code was also attempting to sort even when thesort_by
value wasnone
.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1593874
@miq-bot add_label gaprindashvili/yes, bug, blocker
@d-m-u Please review
@miq-bot assign @gmcculloug
/cc @tinaafitz