Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normal Operating Range cpu/mem usage rate to use avg (instead of max) values #17614

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Normal Operating Range cpu/mem usage rate to use avg (instead of max) values #17614

merged 1 commit into from
Jul 3, 2018

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Jun 19, 2018 •
edited
Loading

@jameswnl jameswnl mentioned this pull request Jun 22, 2018
Merged
@jameswnl
Copy link
Contributor Author

@miq-bot add_labels wip, enhancement

@miq-bot miq-bot changed the title Normal Operating Range cpu/mem usage rate to use avg (instead of max) values [WIP] Normal Operating Range cpu/mem usage rate to use avg (instead of max) values Jun 22, 2018
@jameswnl jameswnl changed the title [WIP] Normal Operating Range cpu/mem usage rate to use avg (instead of max) values Normal Operating Range cpu/mem usage rate to use avg (instead of max) values Jul 2, 2018
@jameswnl
Copy link
Contributor Author

jameswnl commented Jul 2, 2018

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Jul 2, 2018
@jameswnl
Copy link
Contributor Author

jameswnl commented Jul 2, 2018

@miq-bot remove_label enhancement
@miq-bot add_labels bug

@miq-bot miq-bot added bug and removed enhancement labels Jul 2, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2018

Checked commit jameswnl@c4bddc9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 2 offenses detected

app/models/vm_or_template/right_sizing.rb

@agrare agrare self-assigned this Jul 3, 2018
agrare
agrare approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice find @jameswnl

@agrare agrare merged commit 80c0ce5 into ManageIQ:master Jul 3, 2018
@jameswnl jameswnl deleted the nor2 branch July 5, 2018 14:17
@agrare agrare added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug providers/metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameswnl @miq-bot @agrare