Extracting physical ports of a switch to a new page #17593
Conversation
felipedf
changed the title
|
@felipedf where is name used that can't be changed to port_name? I'm not against this just want to make sure it is necessary. |
|
It is used here https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/mixins/generic_show_mixin.rb#L74 It happens when we try to access a detail page, this is the same workaround done here https://github.com/ManageIQ/manageiq/blob/master/app/models/guest_device.rb#L20 |
|
👍 thanks @felipedf |
|
Moving this PR to WIP for now since there is still some discussion ongoing on ManageIQ/manageiq-ui-classic#4141 |
felipedf
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
felipedf
changed the title
felipedf
force-pushed
the
extract_physical_net_ports
branch
from
c6d25b1 to
703380e
Compare
|
@agrare it is good to go, we might change the way we present the detail page for smaller components in a future, but let's keep with the way it is for now |
|
Checked commit felipedf@703380e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Not sure why travis didn't start, closing and reopening to kick it |
Related to: ManageIQ/manageiq-ui-classic#4141