Cashe cloud volumes in ChargebackVm #17585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
cash_cloud_volumes_in_chargeback
branch
from
1a0f74b to
887cc81
Compare
lpichler
force-pushed
the
cash_cloud_volumes_in_chargeback
branch
2 times, most recently
from
744c8c1 to
355cece
Compare
|
@miq-bot add_label blocker, chargeback, perfomance |
|
@lpichler Cannot apply the following label because they are not recognized: perfomance |
lpichler
force-pushed
the
cash_cloud_volumes_in_chargeback
branch
from
355cece to
108ae04
Compare
lpichler
force-pushed
the
cash_cloud_volumes_in_chargeback
branch
from
108ae04 to
ce3bb5d
Compare
|
Checked commit lpichler@ce3bb5d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Jun 14, 2018
|
🤑 ("Cash" v.s. "Cache" in PR title) 😉 |
lpichler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke cloud volume query only when report is run.
Previously query was invoked each time when when method
ChargebackVm.attribute_nameswas called.Based on @NickLaMuro's code and findings. Thanks!
Stats are as part of bigger issue. (Will be added lately)
@miq-bot assign @gtanzillo
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1566452
one of 5 PRs for a fix.