Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [FINE] Change raw_stdout method to fix displaying details of active ansible services #17584

Conversation

hstastna
Copy link

@hstastna hstastna commented Jun 14, 2018

Issue with more info: ManageIQ/manageiq-ui-classic#2470
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1590761
UI PR: ManageIQ/manageiq-ui-classic#4150 (needs to merge after this PR)


Steps to reproduce:

  1. Go to Services > My Services
  2. Click on some service using Ansible (display its details page or click on it in accordion) while Embedded Ansible server role is not active
  3. Click on some Child Service in details page of selected service (or click on it in accordion)
    => nothing happens, child service is not displayed + error:
[----] I, [2018-06-14T15:20:04.648758 #27412:2b07798d59cc]  INFO -- :   Rendered /home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/views/service/_svcs_show.html.haml (2430.0ms)
[----] F, [2018-06-14T15:20:04.648995 #27412:2b07798d59cc] FATAL -- : Error caught: [ActionView::Template::Error] Embedded ansible is disabled
/home/hstastna/manageiq/fine_branch/manageiq/app/models/manageiq/providers/embedded_ansible/provider.rb:14:in `raw_connect'
/home/hstastna/manageiq/fine_branch/manageiq/app/models/manageiq/providers/ansible_tower/shared/provider.rb:41:in `connect'
/home/hstastna/manageiq/fine_branch/manageiq/app/models/provider.rb:49:in `with_provider_connection'
/home/hstastna/manageiq/fine_branch/manageiq/app/models/manageiq/providers/ansible_tower/shared/automation_manager.rb:5:in `with_provider_connection'
/home/hstastna/manageiq/fine_branch/manageiq/app/models/manageiq/providers/ansible_tower/shared/automation_manager/job.rb:138:in `raw_stdout'
/home/hstastna/manageiq/fine_branch/manageiq-ui-classic/app/views/service/_svcs_show.html.haml:47:in `block in __home_hstastna_manageiq_fine_branch_manageiq_ui_classic_app_views_service__svcs_show_html_haml___190407694864775805_69946839755080'


Step 2 from steps to reproduce:
service

Before: (Nothing happens, child service is not displayed + error)
service

After: (with merging PR to UI)
child

Note:
I've created this PR as backport conflicts would very probably occur if we tried to backport #16441 which fixes the BZ for 5.9 and latest master (already backported to gaprindashvili).

@hstastna hstastna changed the title [WIP] Change raw_stdout method to fix displaying details of active ansible services [WIP] [FINE] Change raw_stdout method to fix displaying details of active ansible services Jun 14, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 14, 2018

Checked commit hstastna@1c224cb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants