Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flavor model to :tag_classes: section in miq_expression.yml. #17537

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Add Flavor model to :tag_classes: section in miq_expression.yml. #17537

merged 1 commit into from
Jun 7, 2018

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Jun 6, 2018 •
edited
Loading

It would allow to select Flavor.My Company Tags... when building expressions.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1581501

BEFORE:
screen shot 2018-06-06 at 10 30 52 am

AFTER:
after

@miq-bot add-label bug

@yrudman
add Flavor model to :tag_classes: sections in miq_expression.yml. It …
110969f 
…would allow to select Flavor.My Company Tags... when building expressions.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1581501
@miq-bot miq-bot added the bug label Jun 6, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 6, 2018

Checked commit yrudman@110969f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@yrudman yrudman changed the title Add Flavor model to :tag_classes: sections in miq_expression.yml. Add Flavor model to :tag_classes: section in miq_expression.yml. Jun 6, 2018
@gtanzillo gtanzillo added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 7, 2018
@gtanzillo gtanzillo merged commit 5dcbfb9 into ManageIQ:master Jun 7, 2018
@yrudman yrudman deleted the add-flavor-to-tag_classes branch June 7, 2018 17:34
@yrudman
Copy link
Contributor Author

yrudman commented Jun 7, 2018

@miq-bot add-label gaprindashvili/yes

@agrare agrare mentioned this pull request Jun 12, 2018
Merged
simaishi pushed a commit that referenced this pull request Jul 11, 2018
@gtanzillo @simaishi
Merge pull request #17537 from yrudman/add-flavor-to-tag_classes
0493118 
Add Flavor model to :tag_classes: section in miq_expression.yml.
(cherry picked from commit 5dcbfb9)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591496
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 04931188e02b4227523b9418287c9c3a291eea73
Author: Gregg Tanzillo <[email protected]>
Date:   Thu Jun 7 11:29:17 2018 -0400

    Merge pull request #17537 from yrudman/add-flavor-to-tag_classes
    
    Add Flavor model to :tag_classes: section in miq_expression.yml.
    (cherry picked from commit 5dcbfb9c773d29a511632d0bccb0fd42fb53649e)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yrudman @miq-bot @simaishi @gtanzillo