Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Physical Chassis in the UI #17523

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Adds support for Physical Chassis in the UI #17523

merged 1 commit into from
Jun 14, 2018

Conversation

caiocmpaes
Copy link
Contributor

What this PR does:

  • Adds miq_user_roles for UI Views of Physical Chassis;
  • Adds miq_expression of PhysicalChassis;
  • Adds the internationalization to Lenovo PhysicalChassis class type.

Reason:

  • In order to add Physical Chassis List & Details page in the UI we have to add these configs.

@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2018

Checked commit https://github.com/caiocmpaes/manageiq/commit/d2a7abf920774df2e7c481dd308e8278909030be with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@agrare
Copy link
Member

agrare commented Jun 7, 2018

@h-kataria can you take a look

@caiocmpaes
Copy link
Contributor Author

Hi, @h-kataria Could you take a look at this PR?

@h-kataria
Copy link
Contributor

looks good

@h-kataria h-kataria added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 14, 2018
@h-kataria h-kataria merged commit 511cdae into ManageIQ:master Jun 14, 2018
@caiocmpaes caiocmpaes deleted the configs_to_enable_chassis_ui branch June 14, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants