Create a virtual column for archived for using in the API
#17509
Conversation
app/models/service_template.rb
Outdated
| @@ -411,6 +412,10 @@ def add_resource(rsc, options = {}) | |||
| set_service_type | |||
| end | |||
|
|
|||
| def archived | |||
| archived? | |||
There was a problem hiding this comment.
why is this needed? can virtual columns not have a ?
There was a problem hiding this comment.
Oh I guess it wouldn't work well with the URI then, still new to me so bear with me.
You should add one for active also then if we want to use that in the future
There was a problem hiding this comment.
? has a special meaning in the API context - so I was just making sure to keep things simple in the context of the API
Although I have verified that this does work in the API -
virtual_column :archived?, :type => :boolean
/api/service_templates/<id>?attributes=archived?
LMK if you want me to change it.
There was a problem hiding this comment.
The thing is these are defined in the archived mixin so we would need to add these to every model that includes the mixin, might be better to either use the methods that the mixin provides or add aliases and virtual-columns to the mixin
There was a problem hiding this comment.
Ok, let's go with archived?, since the API can handle it
AparnaKarve
force-pushed
the
add_virtual_col_archived
branch
from
6394758 to
b4d64ff
Compare
|
Checked commit AparnaKarve@b4d64ff with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@agrare Thanks for merging... And apologies I didn't see this comment #17509 (comment) before -- saw it just now after I refreshed the page.
|
Adding a virtual column for
archived?enables us to query it in the API as shown below -/cc @agrare