Add addressable library to Gemfile #17502
Conversation
|
@djberg96 Does this fix the username / password encoding issues for rest-client? |
|
@bdunne If you can be more specific I can look into it, but I'm not immediately sure what you're referring to. |
|
@bdunne I don't think so since that would require internal modifications of the rest-client library. |
|
Does it fix anything other than the rubocop warning? |
|
Generally speaking, it handles special characters better. It also supports url templates, which might be useful in testing. Some relevant links: http://rawsyntax.com/blog/url-validation-in-rails-3-and-ruby-in-general |
|
This pull request is not mergeable. Please rebase and repush. |
|
Checked commits https://github.com/djberg96/manageiq/compare/ea97113068ae74ae4188917bc6bdde8382828fcf~...30d4b7e957178cb367363403912fe72a2afca5bc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Even though addressable is probably a better library than URI in standard library, I don't think it makes sense to change for the sake of change. If there are clear bugs and performance problems with URI that addressable addresses 🤣 , then it makes sense to revisit this. I'm not sure what benefit various RFC standards buys us. My problem is we have lots of our code and gem code that use the URI library and I'm not sure how to have confidence that this code would work or be improved with addressable. Finally, no code is actually going to be using addressable after this change so it's just unused code. |
This PR adds the addressable gem to the Gemfile.
From the github project page: Addressable is a replacement for the URI implementation that is part of Ruby's standard library. It more closely conforms to RFC 3986, RFC 3987, and RFC 6570 (level 4), additionally providing support for IRIs and URI templates.
We already get warnings from rubocop regarding URI.escape. Let's just use a better library.