Add ArchivedMixin to ServiceTemplate #17480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
add_archived_mixin_to_service_template
branch
from
aaaa0a0 to
01613de
Compare
agrare
commented
May 25, 2018
app/models/service_template.rb
Outdated
| @@ -56,6 +57,7 @@ class ServiceTemplate < ApplicationRecord | |||
| has_many :dialogs, -> { distinct }, :through => :resource_actions | |||
|
|
|||
| has_many :miq_requests, :as => :source, :dependent => :nullify | |||
| has_many :active_requests, -> { where(:request_state => %w(active queued)) }, :as => :source, :class_name => "MiqRequest" | |||
There was a problem hiding this comment.
@bzwei can you confirm this covers all "active requests"?
There was a problem hiding this comment.
You can use constants
https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_request.rb#L4
agrare
force-pushed
the
add_archived_mixin_to_service_template
branch
from
d494d8c to
6978d03
Compare
agrare
force-pushed
the
add_archived_mixin_to_service_template
branch
from
6978d03 to
f56ef1f
Compare
agrare
force-pushed
the
add_archived_mixin_to_service_template
branch
from
f56ef1f to
ccdde4b
Compare
|
Checked commits agrare/manageiq@d025b82~...ccdde4b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/service_template.rb
|
This was referenced May 31, 2018
|
Backported to Gaprindashvili via #17481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the archived mixin to service templates to allow for v2v
migration plans to be archived by the user.
ManageIQ/manageiq-v2v#314
Gap backport: #17481
Depends on: ManageIQ/manageiq-schema#207