-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload automate models dialogs during log collection #17445
Merged
bdunne
merged 3 commits into
ManageIQ:master
from
jrafanie:upload_automate_models_dialogs_during_log_collection
May 25, 2018
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,25 +99,28 @@ | |
|
||
context "with post_logs message" do | ||
it "#post_logs will only post current logs if flag enabled" do | ||
message.deliver | ||
message.args.first[:only_current] = true | ||
expect_any_instance_of(MiqServer).to receive(:post_historical_logs).never | ||
expect_any_instance_of(MiqServer).to receive(:post_current_logs).once | ||
expect_any_instance_of(MiqServer).to receive(:post_automate_dialogs).once | ||
expect_any_instance_of(MiqServer).to receive(:post_automate_models).once | ||
message.delivered(*message.deliver) | ||
end | ||
|
||
it "#post_logs will post both historical and current logs if flag nil" do | ||
message.deliver | ||
expect_any_instance_of(MiqServer).to receive(:post_historical_logs).once | ||
expect_any_instance_of(MiqServer).to receive(:post_current_logs).once | ||
expect_any_instance_of(MiqServer).to receive(:post_automate_dialogs).once | ||
expect_any_instance_of(MiqServer).to receive(:post_automate_models).once | ||
message.delivered(*message.deliver) | ||
end | ||
|
||
it "#post_logs will post both historical and current logs if flag false" do | ||
message.deliver | ||
message.args.first[:only_current] = false | ||
expect_any_instance_of(MiqServer).to receive(:post_historical_logs).once | ||
expect_any_instance_of(MiqServer).to receive(:post_current_logs).once | ||
expect_any_instance_of(MiqServer).to receive(:post_automate_dialogs).once | ||
expect_any_instance_of(MiqServer).to receive(:post_automate_models).once | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will rid this file of |
||
message.delivered(*message.deliver) | ||
end | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put this in
Rails.root.join("tmp")
or are you worried about size?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was worried about the size of the file.