Integrate with external Tower Workflow #17440

jameswnl · 2018-05-18T03:11:12Z

https://bugzilla.redhat.com/show_bug.cgi?id=1468339

Part of #17441

jameswnl · 2018-05-18T14:27:29Z

@Fryguy can you take a look? Some modeling work here and so would like to gather feedback early on. thanks

Ladas

👍 looks great

blomquisg · 2018-06-01T20:24:42Z

app/models/manageiq/providers/automation_manager.rb


  has_many :configured_systems,           :dependent => :destroy, :foreign_key => "manager_id"
  has_many :configuration_profiles,       :dependent => :destroy, :foreign_key => "manager_id"
  has_many :configuration_scripts,        :dependent => :destroy, :foreign_key => "manager_id"
+  has_many :workflows,                    :dependent => :destroy, :foreign_key => "manager_id"
+  has_many :workflow_nodes,               :dependent => :destroy, :foreign_key => "manager_id"


I made this comment in the associated schema change, but I think these should be prefixed with configuration to make sure we know why the underlying tables exist.

I'm worried that just calling them workflow makes it look like we're introducing yet another state machine implementation. When in reality, this is inventory data.

blomquisg · 2018-06-01T20:26:10Z

app/models/manager_refresh/inventory/core.rb

+    def has_workflows(options = {})
+      has_inventory({
+        :model_class                 => ::Workflow,
+        :manager_ref                 => [:manager_ref],


Do you have a good idea of what's going to be used for the manager_ref?

This is the native id in Tower for this workflow. We need this in order to ask Tower to execute a particular workflow.

jameswnl · 2018-06-04T20:30:10Z

@miq-bot remove_label wip
@miq-bot add_labels enhancement, providers/ansible_tower

bdunne · 2018-06-06T15:32:54Z

app/models/manageiq/providers/automation_manager.rb

@@ -7,10 +7,12 @@ class ManageIQ::Providers::AutomationManager < ManageIQ::Providers::BaseManager
  require_nested :InventoryGroup
  require_nested :InventoryRootGroup
  require_nested :OrchestrationStack
+  require_nested :ConfigurationWorkflow


Please sort alphabetically

bdunne · 2018-06-06T15:33:52Z

app/models/manageiq/providers/external_automation_manager.rb

@@ -5,4 +5,5 @@ class ManageIQ::Providers::ExternalAutomationManager < ManageIQ::Providers::Auto
  require_nested :ConfigurationScriptSource
  require_nested :ConfiguredSystem
  require_nested :OrchestrationStack
+  require_nested :ConfigurationWorkflow


bdunne · 2018-06-06T15:34:43Z

app/models/manager_refresh/inventory/automation_manager.rb

@@ -3,6 +3,16 @@ module ManagerRefresh::Inventory::AutomationManager
  include ::ManagerRefresh::Inventory::Core

  class_methods do
+    def has_automation_manager_configuration_workflows(options = {})


Can these be renamed as Rubocop suggested?

there are others, so I am not sure if we want to do this. Probably not this PR, even if we want to.

Hey @Ladas thinking about the naming about these has_*, are there meant to be a predicate? or they should be add_*?
That could be confusing rubocop...

Yeah, it's not a question (rubocop is wrong), so let's keep this consistent. FYI @slemrmartin is redoing the interface, so it will not look like this at all

https://bugzilla.redhat.com/show_bug.cgi?id=1468339

miq-bot · 2018-06-07T14:37:38Z

Checked commit jameswnl@dd1215d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 2 offenses detected

app/models/manager_refresh/inventory/automation_manager.rb

❗ - Line 36, Col 9 - Naming/PredicateName - Rename has_automation_manager_configuration_workflows to automation_manager_configuration_workflows?.

app/models/manager_refresh/inventory/core.rb

❗ - Line 44, Col 9 - Naming/PredicateName - Rename has_configuration_workflows to configuration_workflows?.

Based on ManageIQ#17440

Based on ManageIQ/manageiq#17440 (transferred from ManageIQ/manageiq@11b6c65)

miq-bot added the wip label May 18, 2018

jameswnl mentioned this pull request May 18, 2018

Integrate with external Tower Workflow #17441

Closed

Ladas approved these changes May 21, 2018

View reviewed changes

jameswnl force-pushed the workflow branch 5 times, most recently from ff91490 to b49f6c8 Compare June 1, 2018 19:31

blomquisg reviewed Jun 1, 2018

View reviewed changes

jameswnl force-pushed the workflow branch from f998e02 to 2be511b Compare June 4, 2018 19:48

jameswnl changed the title ~~[WIP] Integrate with external Tower Workflow~~ Integrate with external Tower Workflow Jun 4, 2018

miq-bot added enhancement providers/ansible_tower and removed wip labels Jun 4, 2018

jameswnl force-pushed the workflow branch 2 times, most recently from befe6e2 to cd60675 Compare June 5, 2018 18:02

bdunne requested changes Jun 6, 2018

View reviewed changes

jameswnl force-pushed the workflow branch 5 times, most recently from 1525b95 to 448084e Compare June 6, 2018 20:31

jameswnl mentioned this pull request Jun 7, 2018

Integrate with Tower Workflow ManageIQ/manageiq-providers-ansible_tower#86

Merged

Integrate with external Tower Workflow

dd1215d

https://bugzilla.redhat.com/show_bug.cgi?id=1468339

jameswnl force-pushed the workflow branch from 448084e to dd1215d Compare June 7, 2018 14:28

bdunne approved these changes Jun 7, 2018

View reviewed changes

bdunne merged commit 5e454cb into ManageIQ:master Jun 7, 2018

bdunne added the gaprindashvili/no label Jun 7, 2018

bdunne self-assigned this Jun 7, 2018

bdunne added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 7, 2018

jameswnl deleted the workflow branch June 8, 2018 15:57

slemrmartin mentioned this pull request Jun 12, 2018

Persister: InventoryCollection building through add_collection() ManageIQ/manageiq-providers-ansible_tower#81

Merged

2 tasks

slemrmartin added a commit to slemrmartin/manageiq that referenced this pull request Jun 12, 2018

Added IC definition for Tower Workflow

11b6c65

Based on ManageIQ#17440

slemrmartin mentioned this pull request Jun 12, 2018

Added IC Builder definition for Tower Workflow #17571

Merged

agrare pushed a commit to ManageIQ/inventory_refresh that referenced this pull request Aug 28, 2018

Added IC definition for Tower Workflow

a8d4f46

Based on ManageIQ/manageiq#17440 (transferred from ManageIQ/manageiq@11b6c65)

agrare pushed a commit to ManageIQ/inventory_refresh that referenced this pull request Sep 5, 2018

Added IC definition for Tower Workflow

cf759ba

Based on ManageIQ/manageiq#17440 (transferred from ManageIQ/manageiq@11b6c65)

Fryguy added the providers/automation label Jan 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate with external Tower Workflow #17440

Integrate with external Tower Workflow #17440

jameswnl commented May 18, 2018 •

edited

Loading

jameswnl commented May 18, 2018

Ladas left a comment

blomquisg Jun 1, 2018

jameswnl Jun 4, 2018

blomquisg Jun 1, 2018

jameswnl Jun 1, 2018

jameswnl commented Jun 4, 2018

bdunne Jun 6, 2018

jameswnl Jun 6, 2018

bdunne Jun 6, 2018

jameswnl Jun 6, 2018

bdunne Jun 6, 2018

jameswnl Jun 6, 2018

jameswnl Jun 6, 2018

jameswnl Jun 6, 2018

Ladas Jun 7, 2018

miq-bot commented Jun 7, 2018

Integrate with external Tower Workflow #17440

Integrate with external Tower Workflow #17440

Conversation

jameswnl commented May 18, 2018 • edited Loading

jameswnl commented May 18, 2018

Ladas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jameswnl commented Jun 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miq-bot commented Jun 7, 2018

jameswnl commented May 18, 2018 •

edited

Loading