Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read ui url from settings file for dev environment #17435

Merged
merged 1 commit into from
May 17, 2018

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented May 17, 2018

In dev environments we need the ability to set the UI URL
from config/settings.yml. This is used when constructing the
remote_ui_url

This is similar to PR #16185 which implemented the REST URL for dev environments.

In dev environments we need the ability to set the UI URL
from config/settings.yml. This is used when constructing the
remote_ui_url
@mkanoor
Copy link
Contributor Author

mkanoor commented May 17, 2018

@Fryguy @carbonin

Please review.

@mkanoor mkanoor requested review from Fryguy and carbonin May 17, 2018 19:59
@miq-bot
Copy link
Member

miq-bot commented May 17, 2018

Checked commit mkanoor@701650c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@carbonin carbonin self-assigned this May 17, 2018
@carbonin carbonin merged commit b5cd6c4 into ManageIQ:master May 17, 2018
@carbonin carbonin added this to the Sprint 86 Ending May 21, 2018 milestone May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants