Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Vm reconnect if already reconnected #17417

Merged

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented May 14, 2018

Skip Vm reconnect if already reconnected

Spec testing this in ManageIQ/manageiq-providers-azure#256

@Ladas
Copy link
Contributor Author

Ladas commented May 14, 2018

@miq-bot add_label bug
@miq-bot assign @agrare

Skip Vm reconnect if already reconnected
@Ladas Ladas force-pushed the handle_multiple_archived_entities_in_reconnect branch from e020243 to adc35e7 Compare May 14, 2018 12:10
@miq-bot
Copy link
Member

miq-bot commented May 14, 2018

Checked commit Ladas@adc35e7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@agrare
Copy link
Member

agrare commented May 14, 2018

@Ladas what caused multiple entities with the same ref to get into the collection here?

@Ladas
Copy link
Contributor Author

Ladas commented May 14, 2018

@agrare testing it on Azure, where I have 3 providers with overlapping duplicate entities.

@agrare
Copy link
Member

agrare commented May 14, 2018

Which 3 providers? I thought azure just had cloud and network managers

@agrare
Copy link
Member

agrare commented May 14, 2018

I'm good with the change just want to understand what is different here

@Ladas
Copy link
Contributor Author

Ladas commented May 14, 2018

@agrare ah, right, I mean 3 azure cloud providers. :-) But in the end, there is nothing in the DB that would prevent archived duplicates

@agrare agrare merged commit ad4eb1b into ManageIQ:master May 14, 2018
@agrare
Copy link
Member

agrare commented May 14, 2018

Ah okay gotcha, LGTM

@agrare agrare added this to the Sprint 86 Ending May 21, 2018 milestone May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants