Add factories for the Switch and HostSwitch models #17416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
requested changes
May 14, 2018
spec/factories/host_switch.rb
Outdated
| @@ -0,0 +1,3 @@ | |||
| FactoryGirl.define do | |||
| factory :host_switch | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I added a hack so that we don't need to define all of these empty factories.
https://github.com/ManageIQ/manageiq/blob/master/spec/support/missing_factory_helper.rb#L1
spec/factories/switch.rb
Outdated
| @@ -0,0 +1,4 @@ | |||
| FactoryGirl.define do | |||
| factory :switch | |||
There was a problem hiding this comment.
Well, I thought we need a parent factory if I'm creating a specific one...
There was a problem hiding this comment.
I don't think so since it's not inheriting anything. The factory being created is just for the convenience of not needing to type out the class name.
skateman
force-pushed
the
switch-factories
branch
from
42b3583 to
ca71a90
Compare
|
Checked commit skateman@ca71a90 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am writing some tests for infrastructure networking and these factories are required.
@miq-bot add_label test
@miq-bot assign @martinpovolny