Add logging and update upgrade_message for successful registration #17340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems hard to tell whether the entire process of registering, attaching products and enabling repos has finished. https://bugzilla.redhat.com/show_bug.cgi?id=1566562
|
Checked commit bdunne@39828bc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
reviewed
Apr 24, 2018
| @@ -63,6 +63,8 @@ def attempt_registration | |||
| configure_yum_proxy | |||
| # HACK: #enable_repos is not always successful immediately after #attach_products, retry to ensure they are enabled. | |||
| 5.times { repos_enabled? ? break : enable_repos } | |||
| update_attributes(:upgrade_message => "Registration process completed successfully") | |||
There was a problem hiding this comment.
Should this just be "registration successful" like here? Or are these conditions different?
There was a problem hiding this comment.
No. I wanted to differentiate the completion of "subscription-manager register" and the completion of the entire process of registering (register, attach, enable repos).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems hard to tell whether the entire process of registering, attaching
products and enabling repos has finished.
https://bugzilla.redhat.com/show_bug.cgi?id=1566562
cc @lcouzens