Changing the description of the 'vlan' field in provision/network #17306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label gaprindashvili/yes, bug |
|
@agrare, @pkliczewski please review |
agrare
reviewed
Apr 17, 2018
| @@ -439,7 +439,7 @@ | |||
| :dvs: true | |||
| :vlans: true | |||
| :method: :allowed_vlans | |||
| :description: Network | |||
| :description: Virtual Nic Profile id | |||
There was a problem hiding this comment.
Should Nic be NIC since it is an acronym?
The new description will improve the error message displayed when using wrong vlan when provisioning a vm via the rest api. Bug-Url: https://bugzilla.redhat.com/1541036
AlonaKaplan
force-pushed
the
vlan_description
branch
from
80880b0 to
8a8833b
Compare
|
Checked commit AlonaKaplan@8a8833b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Apr 17, 2018
simaishi
pushed a commit
that referenced
this pull request
May 15, 2018
Changing the description of the 'vlan' field in provision/network (cherry picked from commit 9f7f72c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578393
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new description will improve the error message displayed when using
wrong vlan when provisioning a vm via the rest api.
Fixes https://bugzilla.redhat.com/1541036