Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FINE] Bump more_core_extensions to 3.5 #17299

Merged
merged 1 commit into from
Apr 13, 2018
Merged

[FINE] Bump more_core_extensions to 3.5 #17299

merged 1 commit into from
Apr 13, 2018

Conversation

simaishi
Copy link
Contributor

@simaishi
Copy link
Contributor Author

@bdunne @Fryguy please review (and merge since I opened the PR!)

@simaishi simaishi added the bug label Apr 13, 2018
@miq-bot miq-bot changed the title Bump more_core_extensions to 3.5 [FINE] Bump more_core_extensions to 3.5 Apr 13, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2018

Checked commit simaishi@3bc169b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

bdunne
bdunne approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

jrafanie
jrafanie approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit: when travis is 💚

@bdunne bdunne merged commit 10e9d3b into ManageIQ:fine Apr 13, 2018
@bdunne bdunne added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 13, 2018
@bdunne bdunne self-assigned this Apr 13, 2018
@simaishi simaishi deleted the more_core_35 branch April 13, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

@jrafanie jrafanie jrafanie approved these changes

Assignees

@bdunne bdunne

Labels
bug dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simaishi @miq-bot @jrafanie @bdunne