Add timeout knob for monitoring server roles #17265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this be added to |
https://bugzilla.redhat.com/show_bug.cgi?id=1564567 Monitoring server roles as the master server is so important, it should finish and not ever timeout. If it times out, servers will not be able to gain roles. Previously, the default lock timeout of 1 minute is too low in situations where the master server has higher than normal latency to the database. We need to give it more time to finish before timing it out. Additionally, we can specify this value in advanced settings in the server section if 5.minutes is still not enough or just a wrong value.
jrafanie
force-pushed
the
increase_monitor_server_roles_timeout
branch
from
e38ce72 to
1f564cd
Compare
Yeah, I wanted to not expose it but then we have the whole effort to externalize all hardcoded settings to the config file so yeah, I should have put it in settings.yml. Updated now. |
|
Checked commit jrafanie@1f564cd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Apr 10, 2018
simaishi
pushed a commit
that referenced
this pull request
Apr 16, 2018
…_timeout Add timeout knob for monitoring server roles (cherry picked from commit 8b8d86c) https://bugzilla.redhat.com/show_bug.cgi?id=1568159
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 18, 2018
…_timeout Add timeout knob for monitoring server roles (cherry picked from commit 8b8d86c) https://bugzilla.redhat.com/show_bug.cgi?id=1568158
|
Gaprindashvili backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…er_roles_timeout Add timeout knob for monitoring server roles (cherry picked from commit 8b8d86c) https://bugzilla.redhat.com/show_bug.cgi?id=1568159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1564567
Monitoring server roles as the master server is so important, it should
finish and not ever timeout. If it times out, servers will not be able
to gain roles. Previously, the default lock timeout of 1 minute is too
low in situations where the master server has higher than normal
latency to the database. We need to give it more time to finish before
timing it out.
Additionally, we can specify this value in advanced settings in the server
section if 5.minutes is still not enough or just a wrong value.