[WIP] Add v2v transformation validation. #17251
Conversation
| @@ -1,9 +1,53 @@ | |||
| class TransformationMapping < ApplicationRecord | |||
| VM_VALID = N_("OK").freeze | |||
There was a problem hiding this comment.
You do not want to set this as a constant. It will get set once with whatever localization is in place when the model loads. You are trying to honor the current users local which is dynamic.
app/models/vm.rb
Outdated
| @@ -121,6 +121,12 @@ def supported_consoles | |||
| } | |||
| end | |||
|
|
|||
| def v2v_migrated? | |||
| ServiceResource.where(:resource => self, :status => 'complete').any? do |resource| | |||
There was a problem hiding this comment.
@bzwei Is complete a constant somewhere in the transformation models that we can reference?
I actually think this is should be "Completed" from here: app/models/service_template_transformation_plan_task.rb#L30. Which feels like it should really be a constant in the model.
app/models/transformation_mapping.rb
Outdated
| def select_vms | ||
| valid_list = [] | ||
|
|
||
| Vm.each do |vm| |
There was a problem hiding this comment.
While the .each method does not exist on the Vm model is this really what we want to do? It will return every infra and cloud VM object in the database. It should at least be limited to the source provider defined in the mapping.
There was a problem hiding this comment.
You can aggregate all source clusters from the mapping and find all VMs under the clusters.
app/models/transformation_mapping.rb
Outdated
| def select_vms | ||
| valid_list = [] | ||
|
|
||
| Vm.each do |vm| |
There was a problem hiding this comment.
You can aggregate all source clusters from the mapping and find all VMs under the clusters.
app/models/vm.rb
Outdated
| @@ -121,6 +121,12 @@ def supported_consoles | |||
| } | |||
| end | |||
|
|
|||
| def v2v_migrated? | |||
There was a problem hiding this comment.
The purpose of the method is to identify whether the VM can be added to a plan. A valid VM is the one has ServiceResource#status as Failed or never exists in ServiceResource.
Also reconsider the method name.
app/models/vm.rb
Outdated
| @@ -121,6 +121,12 @@ def supported_consoles | |||
| } | |||
| end | |||
|
|
|||
| def v2v_migrated? | |||
| ServiceResource.where(:resource => self, :status => 'complete').any? do |resource| | |||
| ServiceTemplate.find(resource.service_template_id).kind_of?(ServiceTemplateTransformationPlan) | |||
There was a problem hiding this comment.
why another query? Can be resource.service_template.kind_of?(ServiceTemplateTransformationPlan).
|
Checked commit lfu@0ca2d4a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Combined with #17177. |
Follow up of #17177.
@miq-bot assign @gmcculloug
@miq-bot add_label enhancement, transformation
cc @bzwei