Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MulticastLogger#datetime_formatter #17223

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Fix MulticastLogger#datetime_formatter #17223

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26ed45e
Fix `MulticastLogger#datetime_formatter`
NickLaMuro Mar 28, 2018
2a30a53
Add integration tests for vmdb/loggers.rb
NickLaMuro Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/vmdb/loggers/multicast_logger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ class MulticastLogger < Logger

def initialize(*loggers)
require 'set'
@loggers = Set.new(loggers)
@level = DEBUG
@loggers = Set.new(loggers)
@level = DEBUG
@default_formatter = VMDBLogger::Formatter.new
Copy link
Member Author

@NickLaMuro NickLaMuro Mar 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative for this is we could call super, but incase that would break other things, we decided it would be better to start with this change for now, since it will modify less things in doing so (since less things would be called in that super call). Up for debate though.

@formatter = nil
end

def level=(new_level)
Expand Down