Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the method signatures for ServiceTemplateContainerTemplate. #17221

Merged

Conversation

lfu
Copy link
Member

@lfu lfu commented Mar 28, 2018

Change the signature of create_catalog_item/update_catalog_item to comply with REST API.

https://bugzilla.redhat.com/show_bug.cgi?id=1561604
#17211

@miq-bot assign @gmcculloug
@miq-bot add_label bug, services, gaprindashvili/yes

cc @mkanoor @bzwei

Change the signature of create_catalog_item/update_catalog_item to comply with REST API.

ManageIQ#17211
@gmcculloug
Copy link
Member

@lfu We are going to need a BZ to back-port this to gaprindashvili.

@gmcculloug gmcculloug merged commit bdfb3e7 into ManageIQ:master Mar 28, 2018
@gmcculloug gmcculloug added this to the Sprint 83 Ending Apr 9, 2018 milestone Mar 28, 2018
simaishi pushed a commit that referenced this pull request Apr 2, 2018
Change the method signatures for ServiceTemplateContainerTemplate.
(cherry picked from commit bdfb3e7)

https://bugzilla.redhat.com/show_bug.cgi?id=1562779
@simaishi
Copy link
Contributor

simaishi commented Apr 2, 2018

Gaprindashvili backport details:

$ git log -1
commit 1dac6e3a0f7f71e59311de552e566d9017d33258
Author: Greg McCullough <[email protected]>
Date:   Wed Mar 28 11:05:18 2018 -0400

    Merge pull request #17221 from lfu/container_template_service_signature
    
    Change the method signatures for ServiceTemplateContainerTemplate.
    (cherry picked from commit bdfb3e70ca21827d5a9e21f8f29714bffdf07ade)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1562779

@lfu lfu deleted the container_template_service_signature branch September 29, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants