Makes http_proxy_uri class method #17218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instance method uses new class method, which is needed by provider validation. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552114 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559019
1 task
|
@slemrmartin ManageIQ/manageiq-ui-classic#3693 is |
|
@simaishi yes this should be fine back on G branch |
simaishi
pushed a commit
that referenced
this pull request
Apr 3, 2018
…-proxy Makes http_proxy_uri class method (cherry picked from commit 1c45ec3) https://bugzilla.redhat.com/show_bug.cgi?id=1563267 https://bugzilla.redhat.com/show_bug.cgi?id=1563268
|
Thanks Adam. Gaprindashvili backport details: |
1 task
|
@slemrmartin @agrare Can this and ManageIQ/manageiq-ui-classic#3693 also go to Fine branch? The BZ now has cfme-5.8.z flag. |
|
@simaishi This looks like it should be able to go back to fine without a problem |
|
@agrare thanks! |
|
@slemrmartin Looks like cloud validation code isn't in Fine branch in manageiq-ui-classic... Also, BZ had cfme-5.8.z flag, but the description says it's not a problem in Fine branch. Please clarify what need to go to Fine branch, if any. |
|
@miq-bot add_label fine/no |
simaishi
pushed a commit
that referenced
this pull request
Apr 23, 2018
…-proxy Makes http_proxy_uri class method (cherry picked from commit 1c45ec3) https://bugzilla.redhat.com/show_bug.cgi?id=1569532
simaishi
added a commit
that referenced
this pull request
Apr 23, 2018
…der-with-proxy" This reverts commit a4415eb.
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…der-with-proxy Makes http_proxy_uri class method (cherry picked from commit 1c45ec3) https://bugzilla.redhat.com/show_bug.cgi?id=1569532
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…ew-provider-with-proxy" This reverts commit a4415eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instance method uses new class method.
Class method needed by UI when adding new cloud provider and validating it.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1552114
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1559019
PR: ManageIQ/manageiq-ui-classic#3693
Cc @agrare