Fix provider proxy settings fallback #17205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VMDB::Utils.http_proxy_uri uses per-provider proxy settings first, then falls back to the base Settings.http_proxy. It was doing this with `::Settings.http_proxy[proxy_config] || ::Settings.http_proxy` but `::Settings.http_proxy[proxy_config]` wasn't returning nil so it was never falling back to the base proxy settings.
|
Checked commit agrare@edde34b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/lib/vmdb/util_spec.rb
|
|
Thanks @bdunne ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VMDB::Utils.http_proxy_uri uses per-provider proxy settings first,
then falls back to the base Settings.http_proxy. It was doing this with
::Settings.http_proxy[proxy_config] || ::Settings.http_proxybut::Settings.http_proxy[proxy_config]wasn't returning nil so it wasnever falling back to the base proxy settings.
cc @Fryguy @blomquisg