Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Storage Total' field from Chargeback Preview reports #17199

Conversation

hstastna
Copy link

@hstastna hstastna commented Mar 26, 2018

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1533671

Remove 'Storage Total' field from Chargeback Preview reports, which were displayed after clicking on Monitoring -> Chargeback Preview from summary page of a VM.


Before:
storage_total_before

After:
storage_total_after

@hstastna
Copy link
Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Mar 26, 2018
@miq-bot
Copy link
Member

miq-bot commented Mar 26, 2018

Checked commit hstastna@19ed579 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@hstastna
Copy link
Author

@miq-bot add_label gaprindashvili/yes

@hstastna
Copy link
Author

@martinpovolny @mzazrivec What do you think about this change? Thanks! :)

@martinpovolny
Copy link
Member

ping @lpichler

Copy link
Contributor

@lpichler lpichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@martinpovolny martinpovolny merged commit a610397 into ManageIQ:master May 24, 2018
@martinpovolny martinpovolny self-assigned this May 24, 2018
@martinpovolny martinpovolny added this to the Sprint 87 Ending Jun 4, 2018 milestone May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants