Fix establishing relations of tenants and cloud tenants between different cloud tenant -> tenant sync #17190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
changed the title
lpichler
changed the title
it can happen when the new user has greater count of cloud tenants than previous provider's user and some of them have different names so parent of existing tenant was not updated correcltly.
lpichler
force-pushed
the
fix_establishing_relations_in_tenant_sync
branch
from
80fcc7f to
dc75287
Compare
…columns because such source (CloudTenant) no longer exists
lpichler
force-pushed
the
fix_establishing_relations_in_tenant_sync
branch
3 times, most recently
from
e29b4bc to
9616903
Compare
lpichler
changed the title
lpichler
force-pushed
the
fix_establishing_relations_in_tenant_sync
branch
from
9616903 to
85cab6b
Compare
lpichler
force-pushed
the
fix_establishing_relations_in_tenant_sync
branch
from
85cab6b to
10a49ba
Compare
there is several cases when user of provider is changed and cloud tenants are changed as well. Each case is testing resulted tenant and all his relations as parent, children, source_tenant and source.
lpichler
force-pushed
the
fix_establishing_relations_in_tenant_sync
branch
from
10a49ba to
59d8272
Compare
|
Checked commits lpichler/manageiq@e29b4d3~...59d8272 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 2, 2018
…_tenant_sync Fix establishing relations of tenants and cloud tenants between different cloud tenant -> tenant sync (cherry picked from commit d03161f) https://bugzilla.redhat.com/show_bug.cgi?id=1562772
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 9, 2018
…_tenant_sync Fix establishing relations of tenants and cloud tenants between different cloud tenant -> tenant sync (cherry picked from commit d03161f) https://bugzilla.redhat.com/show_bug.cgi?id=1562773
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…tions_in_tenant_sync Fix establishing relations of tenants and cloud tenants between different cloud tenant -> tenant sync (cherry picked from commit d03161f) https://bugzilla.redhat.com/show_bug.cgi?id=1562773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main case:
about testing
This implies couple cases and this PR is covering them by specs.
Each case is described in comments.
Testing is done by testing all relations of synced tenant. So for each result tenant is tested his source, cloud_tenant's,source_tenant, children and parent.
This fully covering result tree of tenant.
Fixes here
Is it basically continuation of @gtanzillo 's fix #16144 and
and #16144 is fixing the BZ. But during this investigation have been found some bugs related to uncovered some relations.
we need to nil out source_id and source_type
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1498045
@miq-bot add_label blocker, bug, gaprindashvili/yes, fine/yes
@miq-bot assign @gtanzillo