Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail and name to the new update event group #17164

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 16, 2018

A new event group "update" was added for the amazon provider [0], we need to
also add the name and detail properties to the group in the main repo.

[0] ManageIQ/manageiq-providers-amazon#415

A new event group "update" was added for the amazon provider, we need to
also add the name and detail properties to the group in the main repo.
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified ui-classic specs go green with this, thanks! :)

@martinpovolny martinpovolny merged commit 2adc8e1 into ManageIQ:master Mar 16, 2018
@martinpovolny martinpovolny self-assigned this Mar 16, 2018
@martinpovolny martinpovolny added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 16, 2018
@martinpovolny
Copy link
Member

Thx!

@agrare agrare deleted the add_detail_and_name_to_new_update_event_group branch March 16, 2018 14:14
@simaishi
Copy link
Contributor

Changing to gaprindashvili/yes to match ManageIQ/manageiq-providers-amazon#415

@juliancheal
Copy link
Member

@miq-bot add_label fine/yes

/cc @simaishi ManageIQ/manageiq-providers-amazon#415 needs to be backported too

simaishi pushed a commit that referenced this pull request Mar 20, 2018
…te_event_group

Add detail and name to the new update event group
(cherry picked from commit 2adc8e1)

https://bugzilla.redhat.com/show_bug.cgi?id=1558594
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 355c506013eb654a317c99b4775e2699a4e8027f
Author: Martin Povolny <[email protected]>
Date:   Fri Mar 16 15:04:43 2018 +0100

    Merge pull request #17164 from agrare/add_detail_and_name_to_new_update_event_group
    
    Add detail and name to the new update event group
    (cherry picked from commit 2adc8e15d6e7b4e8f597bf41d54c5e6e29e69f79)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1558594

simaishi pushed a commit that referenced this pull request Apr 9, 2018
…te_event_group

Add detail and name to the new update event group
(cherry picked from commit 2adc8e1)

https://bugzilla.redhat.com/show_bug.cgi?id=1558595
@simaishi
Copy link
Contributor

simaishi commented Apr 9, 2018

Fine backport details:

$ git log -1
commit c23f98f46eaacc11138c1885fac45fe53201b6b6
Author: Martin Povolny <[email protected]>
Date:   Fri Mar 16 15:04:43 2018 +0100

    Merge pull request #17164 from agrare/add_detail_and_name_to_new_update_event_group
    
    Add detail and name to the new update event group
    (cherry picked from commit 2adc8e15d6e7b4e8f597bf41d54c5e6e29e69f79)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1558595

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…new_update_event_group

Add detail and name to the new update event group
(cherry picked from commit 2adc8e1)

https://bugzilla.redhat.com/show_bug.cgi?id=1558595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants