Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicalRack refresh action #17162

Merged
merged 1 commit into from
May 30, 2018
Merged

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Mar 15, 2018

This PR is able to:

  • Add method to the PhysicalRack model to handle refresh action

@miq-bot miq-bot added the wip label Mar 15, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2018

This pull request is not mergeable. Please rebase and repush.

@felipedf felipedf force-pushed the rack_ui_toolbar branch 3 times, most recently from 3f82d7d to 9fa3368 Compare May 11, 2018 17:33
@felipedf felipedf changed the title [WIP] PhysicalRack refresh action PhysicalRack refresh action May 11, 2018
@miq-bot miq-bot removed the wip label May 11, 2018
@miq-bot
Copy link
Member

miq-bot commented May 14, 2018

This pull request is not mergeable. Please rebase and repush.

@felipedf
Copy link
Member Author

@miq-bot assign @agrare
/cc @martinpovolny

@martinpovolny
Copy link
Member

Should you also add the feature to certain roles? Or is that handled on a parent feature level?

@felipedf
Copy link
Member Author

You are right, fixed 👍

@miq-bot
Copy link
Member

miq-bot commented May 30, 2018

Checked commit felipedf@257b0f9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare agrare merged commit dc5c899 into ManageIQ:master May 30, 2018
@agrare agrare added this to the Sprint 87 Ending Jun 4, 2018 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants